Explorar o código

net: Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags()

Am I just being particularly dim today, or can the call to
dev->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() never
happen?

We've just set dev->flags = flags & IFF_MULTICAST, effectively. So the
condition '(dev->flags ^ flags) & IFF_MULTICAST' is _never_ going to be
true.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
David Woodhouse %!s(int64=17) %!d(string=hai) anos
pai
achega
0e91796eb4
Modificáronse 1 ficheiros con 1 adicións e 1 borrados
  1. 1 1
      net/core/dev.c

+ 1 - 1
net/core/dev.c

@@ -3141,7 +3141,7 @@ int dev_change_flags(struct net_device *dev, unsigned flags)
 	 *	Load in the correct multicast list now the flags have changed.
 	 *	Load in the correct multicast list now the flags have changed.
 	 */
 	 */
 
 
-	if (dev->change_rx_flags && (dev->flags ^ flags) & IFF_MULTICAST)
+	if (dev->change_rx_flags && (old_flags ^ flags) & IFF_MULTICAST)
 		dev->change_rx_flags(dev, IFF_MULTICAST);
 		dev->change_rx_flags(dev, IFF_MULTICAST);
 
 
 	dev_set_rx_mode(dev);
 	dev_set_rx_mode(dev);