Forráskód Böngészése

net: move xtsonic's probe function to .devinit.text

A pointer to xtsonic_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Chris Zankel <chris@zankel.net>
Cc: David S. Miller <davem@davemloft.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
Uwe Kleine-König 16 éve
szülő
commit
0c9cd395fa
1 módosított fájl, 1 hozzáadás és 1 törlés
  1. 1 1
      drivers/net/xtsonic.c

+ 1 - 1
drivers/net/xtsonic.c

@@ -239,7 +239,7 @@ out:
  * Actually probing is superfluous but we're paranoid.
  * Actually probing is superfluous but we're paranoid.
  */
  */
 
 
-int __init xtsonic_probe(struct platform_device *pdev)
+int __devinit xtsonic_probe(struct platform_device *pdev)
 {
 {
 	struct net_device *dev;
 	struct net_device *dev;
 	struct sonic_local *lp;
 	struct sonic_local *lp;