|
@@ -980,11 +980,29 @@ static void assert_transcoder_disabled(struct drm_i915_private *dev_priv,
|
|
|
pipe_name(pipe));
|
|
|
}
|
|
|
|
|
|
+static bool dp_pipe_enabled(struct drm_i915_private *dev_priv, enum pipe pipe,
|
|
|
+ int reg, u32 port_sel, u32 val)
|
|
|
+{
|
|
|
+ if ((val & DP_PORT_EN) == 0)
|
|
|
+ return false;
|
|
|
+
|
|
|
+ if (HAS_PCH_CPT(dev_priv->dev)) {
|
|
|
+ u32 trans_dp_ctl_reg = TRANS_DP_CTL(pipe);
|
|
|
+ u32 trans_dp_ctl = I915_READ(trans_dp_ctl_reg);
|
|
|
+ if ((trans_dp_ctl & TRANS_DP_PORT_SEL_MASK) != port_sel)
|
|
|
+ return false;
|
|
|
+ } else {
|
|
|
+ if ((val & DP_PIPE_MASK) != (pipe << 30))
|
|
|
+ return false;
|
|
|
+ }
|
|
|
+ return true;
|
|
|
+}
|
|
|
+
|
|
|
static void assert_pch_dp_disabled(struct drm_i915_private *dev_priv,
|
|
|
- enum pipe pipe, int reg)
|
|
|
+ enum pipe pipe, int reg, u32 port_sel)
|
|
|
{
|
|
|
u32 val = I915_READ(reg);
|
|
|
- WARN(DP_PIPE_ENABLED(val, pipe),
|
|
|
+ WARN(dp_pipe_enabled(dev_priv, pipe, reg, port_sel, val),
|
|
|
"PCH DP (0x%08x) enabled on transcoder %c, should be disabled\n",
|
|
|
reg, pipe_name(pipe));
|
|
|
}
|
|
@@ -1004,9 +1022,9 @@ static void assert_pch_ports_disabled(struct drm_i915_private *dev_priv,
|
|
|
int reg;
|
|
|
u32 val;
|
|
|
|
|
|
- assert_pch_dp_disabled(dev_priv, pipe, PCH_DP_B);
|
|
|
- assert_pch_dp_disabled(dev_priv, pipe, PCH_DP_C);
|
|
|
- assert_pch_dp_disabled(dev_priv, pipe, PCH_DP_D);
|
|
|
+ assert_pch_dp_disabled(dev_priv, pipe, PCH_DP_B, TRANS_DP_PORT_SEL_B);
|
|
|
+ assert_pch_dp_disabled(dev_priv, pipe, PCH_DP_C, TRANS_DP_PORT_SEL_C);
|
|
|
+ assert_pch_dp_disabled(dev_priv, pipe, PCH_DP_D, TRANS_DP_PORT_SEL_D);
|
|
|
|
|
|
reg = PCH_ADPA;
|
|
|
val = I915_READ(reg);
|
|
@@ -1276,6 +1294,17 @@ static void intel_disable_pipe(struct drm_i915_private *dev_priv,
|
|
|
intel_wait_for_pipe_off(dev_priv->dev, pipe);
|
|
|
}
|
|
|
|
|
|
+/*
|
|
|
+ * Plane regs are double buffered, going from enabled->disabled needs a
|
|
|
+ * trigger in order to latch. The display address reg provides this.
|
|
|
+ */
|
|
|
+static void intel_flush_display_plane(struct drm_i915_private *dev_priv,
|
|
|
+ enum plane plane)
|
|
|
+{
|
|
|
+ I915_WRITE(DSPADDR(plane), I915_READ(DSPADDR(plane)));
|
|
|
+ I915_WRITE(DSPSURF(plane), I915_READ(DSPSURF(plane)));
|
|
|
+}
|
|
|
+
|
|
|
/**
|
|
|
* intel_enable_plane - enable a display plane on a given pipe
|
|
|
* @dev_priv: i915 private structure
|
|
@@ -1299,20 +1328,10 @@ static void intel_enable_plane(struct drm_i915_private *dev_priv,
|
|
|
return;
|
|
|
|
|
|
I915_WRITE(reg, val | DISPLAY_PLANE_ENABLE);
|
|
|
+ intel_flush_display_plane(dev_priv, plane);
|
|
|
intel_wait_for_vblank(dev_priv->dev, pipe);
|
|
|
}
|
|
|
|
|
|
-/*
|
|
|
- * Plane regs are double buffered, going from enabled->disabled needs a
|
|
|
- * trigger in order to latch. The display address reg provides this.
|
|
|
- */
|
|
|
-static void intel_flush_display_plane(struct drm_i915_private *dev_priv,
|
|
|
- enum plane plane)
|
|
|
-{
|
|
|
- u32 reg = DSPADDR(plane);
|
|
|
- I915_WRITE(reg, I915_READ(reg));
|
|
|
-}
|
|
|
-
|
|
|
/**
|
|
|
* intel_disable_plane - disable a display plane
|
|
|
* @dev_priv: i915 private structure
|
|
@@ -1338,19 +1357,24 @@ static void intel_disable_plane(struct drm_i915_private *dev_priv,
|
|
|
}
|
|
|
|
|
|
static void disable_pch_dp(struct drm_i915_private *dev_priv,
|
|
|
- enum pipe pipe, int reg)
|
|
|
+ enum pipe pipe, int reg, u32 port_sel)
|
|
|
{
|
|
|
u32 val = I915_READ(reg);
|
|
|
- if (DP_PIPE_ENABLED(val, pipe))
|
|
|
+ if (dp_pipe_enabled(dev_priv, pipe, reg, port_sel, val)) {
|
|
|
+ DRM_DEBUG_KMS("Disabling pch dp %x on pipe %d\n", reg, pipe);
|
|
|
I915_WRITE(reg, val & ~DP_PORT_EN);
|
|
|
+ }
|
|
|
}
|
|
|
|
|
|
static void disable_pch_hdmi(struct drm_i915_private *dev_priv,
|
|
|
enum pipe pipe, int reg)
|
|
|
{
|
|
|
u32 val = I915_READ(reg);
|
|
|
- if (HDMI_PIPE_ENABLED(val, pipe))
|
|
|
+ if (HDMI_PIPE_ENABLED(val, pipe)) {
|
|
|
+ DRM_DEBUG_KMS("Disabling pch HDMI %x on pipe %d\n",
|
|
|
+ reg, pipe);
|
|
|
I915_WRITE(reg, val & ~PORT_ENABLE);
|
|
|
+ }
|
|
|
}
|
|
|
|
|
|
/* Disable any ports connected to this transcoder */
|
|
@@ -1362,9 +1386,9 @@ static void intel_disable_pch_ports(struct drm_i915_private *dev_priv,
|
|
|
val = I915_READ(PCH_PP_CONTROL);
|
|
|
I915_WRITE(PCH_PP_CONTROL, val | PANEL_UNLOCK_REGS);
|
|
|
|
|
|
- disable_pch_dp(dev_priv, pipe, PCH_DP_B);
|
|
|
- disable_pch_dp(dev_priv, pipe, PCH_DP_C);
|
|
|
- disable_pch_dp(dev_priv, pipe, PCH_DP_D);
|
|
|
+ disable_pch_dp(dev_priv, pipe, PCH_DP_B, TRANS_DP_PORT_SEL_B);
|
|
|
+ disable_pch_dp(dev_priv, pipe, PCH_DP_C, TRANS_DP_PORT_SEL_C);
|
|
|
+ disable_pch_dp(dev_priv, pipe, PCH_DP_D, TRANS_DP_PORT_SEL_D);
|
|
|
|
|
|
reg = PCH_ADPA;
|
|
|
val = I915_READ(reg);
|
|
@@ -2096,7 +2120,7 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
|
|
|
|
|
|
/* no fb bound */
|
|
|
if (!crtc->fb) {
|
|
|
- DRM_DEBUG_KMS("No FB bound\n");
|
|
|
+ DRM_ERROR("No FB bound\n");
|
|
|
return 0;
|
|
|
}
|
|
|
|
|
@@ -2105,6 +2129,7 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
|
|
|
case 1:
|
|
|
break;
|
|
|
default:
|
|
|
+ DRM_ERROR("no plane for crtc\n");
|
|
|
return -EINVAL;
|
|
|
}
|
|
|
|
|
@@ -2114,6 +2139,7 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
|
|
|
NULL);
|
|
|
if (ret != 0) {
|
|
|
mutex_unlock(&dev->struct_mutex);
|
|
|
+ DRM_ERROR("pin & fence failed\n");
|
|
|
return ret;
|
|
|
}
|
|
|
|
|
@@ -2142,6 +2168,7 @@ intel_pipe_set_base(struct drm_crtc *crtc, int x, int y,
|
|
|
if (ret) {
|
|
|
i915_gem_object_unpin(to_intel_framebuffer(crtc->fb)->obj);
|
|
|
mutex_unlock(&dev->struct_mutex);
|
|
|
+ DRM_ERROR("failed to update base address\n");
|
|
|
return ret;
|
|
|
}
|
|
|
|
|
@@ -2248,6 +2275,18 @@ static void intel_fdi_normal_train(struct drm_crtc *crtc)
|
|
|
FDI_FE_ERRC_ENABLE);
|
|
|
}
|
|
|
|
|
|
+static void cpt_phase_pointer_enable(struct drm_device *dev, int pipe)
|
|
|
+{
|
|
|
+ struct drm_i915_private *dev_priv = dev->dev_private;
|
|
|
+ u32 flags = I915_READ(SOUTH_CHICKEN1);
|
|
|
+
|
|
|
+ flags |= FDI_PHASE_SYNC_OVR(pipe);
|
|
|
+ I915_WRITE(SOUTH_CHICKEN1, flags); /* once to unlock... */
|
|
|
+ flags |= FDI_PHASE_SYNC_EN(pipe);
|
|
|
+ I915_WRITE(SOUTH_CHICKEN1, flags); /* then again to enable */
|
|
|
+ POSTING_READ(SOUTH_CHICKEN1);
|
|
|
+}
|
|
|
+
|
|
|
/* The FDI link training functions for ILK/Ibexpeak. */
|
|
|
static void ironlake_fdi_link_train(struct drm_crtc *crtc)
|
|
|
{
|
|
@@ -2398,6 +2437,9 @@ static void gen6_fdi_link_train(struct drm_crtc *crtc)
|
|
|
POSTING_READ(reg);
|
|
|
udelay(150);
|
|
|
|
|
|
+ if (HAS_PCH_CPT(dev))
|
|
|
+ cpt_phase_pointer_enable(dev, pipe);
|
|
|
+
|
|
|
for (i = 0; i < 4; i++ ) {
|
|
|
reg = FDI_TX_CTL(pipe);
|
|
|
temp = I915_READ(reg);
|
|
@@ -2514,6 +2556,9 @@ static void ivb_manual_fdi_link_train(struct drm_crtc *crtc)
|
|
|
POSTING_READ(reg);
|
|
|
udelay(150);
|
|
|
|
|
|
+ if (HAS_PCH_CPT(dev))
|
|
|
+ cpt_phase_pointer_enable(dev, pipe);
|
|
|
+
|
|
|
for (i = 0; i < 4; i++ ) {
|
|
|
reg = FDI_TX_CTL(pipe);
|
|
|
temp = I915_READ(reg);
|
|
@@ -2623,6 +2668,17 @@ static void ironlake_fdi_pll_enable(struct drm_crtc *crtc)
|
|
|
}
|
|
|
}
|
|
|
|
|
|
+static void cpt_phase_pointer_disable(struct drm_device *dev, int pipe)
|
|
|
+{
|
|
|
+ struct drm_i915_private *dev_priv = dev->dev_private;
|
|
|
+ u32 flags = I915_READ(SOUTH_CHICKEN1);
|
|
|
+
|
|
|
+ flags &= ~(FDI_PHASE_SYNC_EN(pipe));
|
|
|
+ I915_WRITE(SOUTH_CHICKEN1, flags); /* once to disable... */
|
|
|
+ flags &= ~(FDI_PHASE_SYNC_OVR(pipe));
|
|
|
+ I915_WRITE(SOUTH_CHICKEN1, flags); /* then again to lock */
|
|
|
+ POSTING_READ(SOUTH_CHICKEN1);
|
|
|
+}
|
|
|
static void ironlake_fdi_disable(struct drm_crtc *crtc)
|
|
|
{
|
|
|
struct drm_device *dev = crtc->dev;
|
|
@@ -2652,6 +2708,8 @@ static void ironlake_fdi_disable(struct drm_crtc *crtc)
|
|
|
I915_WRITE(FDI_RX_CHICKEN(pipe),
|
|
|
I915_READ(FDI_RX_CHICKEN(pipe) &
|
|
|
~FDI_RX_PHASE_SYNC_POINTER_EN));
|
|
|
+ } else if (HAS_PCH_CPT(dev)) {
|
|
|
+ cpt_phase_pointer_disable(dev, pipe);
|
|
|
}
|
|
|
|
|
|
/* still set train pattern 1 */
|
|
@@ -2862,14 +2920,18 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc)
|
|
|
I915_WRITE(PF_WIN_SZ(pipe), dev_priv->pch_pf_size);
|
|
|
}
|
|
|
|
|
|
+ /*
|
|
|
+ * On ILK+ LUT must be loaded before the pipe is running but with
|
|
|
+ * clocks enabled
|
|
|
+ */
|
|
|
+ intel_crtc_load_lut(crtc);
|
|
|
+
|
|
|
intel_enable_pipe(dev_priv, pipe, is_pch_port);
|
|
|
intel_enable_plane(dev_priv, plane, pipe);
|
|
|
|
|
|
if (is_pch_port)
|
|
|
ironlake_pch_enable(crtc);
|
|
|
|
|
|
- intel_crtc_load_lut(crtc);
|
|
|
-
|
|
|
mutex_lock(&dev->struct_mutex);
|
|
|
intel_update_fbc(dev);
|
|
|
mutex_unlock(&dev->struct_mutex);
|
|
@@ -4538,7 +4600,9 @@ static bool intel_choose_pipe_bpp_dither(struct drm_crtc *crtc,
|
|
|
if (connector->encoder != encoder)
|
|
|
continue;
|
|
|
|
|
|
- if (connector->display_info.bpc < display_bpc) {
|
|
|
+ /* Don't use an invalid EDID bpc value */
|
|
|
+ if (connector->display_info.bpc &&
|
|
|
+ connector->display_info.bpc < display_bpc) {
|
|
|
DRM_DEBUG_DRIVER("clamping display bpc (was %d) to EDID reported max of %d\n", display_bpc, connector->display_info.bpc);
|
|
|
display_bpc = connector->display_info.bpc;
|
|
|
}
|
|
@@ -5153,7 +5217,8 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
|
|
|
temp |= PIPE_12BPC;
|
|
|
break;
|
|
|
default:
|
|
|
- WARN(1, "intel_choose_pipe_bpp returned invalid value\n");
|
|
|
+ WARN(1, "intel_choose_pipe_bpp returned invalid value %d\n",
|
|
|
+ pipe_bpp);
|
|
|
temp |= PIPE_8BPC;
|
|
|
pipe_bpp = 24;
|
|
|
break;
|
|
@@ -5238,7 +5303,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
|
|
|
} else if (is_sdvo && is_tv)
|
|
|
factor = 20;
|
|
|
|
|
|
- if (clock.m1 < factor * clock.n)
|
|
|
+ if (clock.m < factor * clock.n)
|
|
|
fp |= FP_CB_TUNE;
|
|
|
|
|
|
dpll = 0;
|
|
@@ -5516,6 +5581,8 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
|
|
|
|
|
|
drm_vblank_post_modeset(dev, pipe);
|
|
|
|
|
|
+ intel_crtc->dpms_mode = DRM_MODE_DPMS_ON;
|
|
|
+
|
|
|
return ret;
|
|
|
}
|
|
|
|
|
@@ -7714,10 +7781,12 @@ static void gen6_init_clock_gating(struct drm_device *dev)
|
|
|
ILK_DPARB_CLK_GATE |
|
|
|
ILK_DPFD_CLK_GATE);
|
|
|
|
|
|
- for_each_pipe(pipe)
|
|
|
+ for_each_pipe(pipe) {
|
|
|
I915_WRITE(DSPCNTR(pipe),
|
|
|
I915_READ(DSPCNTR(pipe)) |
|
|
|
DISPPLANE_TRICKLE_FEED_DISABLE);
|
|
|
+ intel_flush_display_plane(dev_priv, pipe);
|
|
|
+ }
|
|
|
}
|
|
|
|
|
|
static void ivybridge_init_clock_gating(struct drm_device *dev)
|
|
@@ -7734,10 +7803,12 @@ static void ivybridge_init_clock_gating(struct drm_device *dev)
|
|
|
|
|
|
I915_WRITE(ILK_DSPCLK_GATE, IVB_VRHUNIT_CLK_GATE);
|
|
|
|
|
|
- for_each_pipe(pipe)
|
|
|
+ for_each_pipe(pipe) {
|
|
|
I915_WRITE(DSPCNTR(pipe),
|
|
|
I915_READ(DSPCNTR(pipe)) |
|
|
|
DISPPLANE_TRICKLE_FEED_DISABLE);
|
|
|
+ intel_flush_display_plane(dev_priv, pipe);
|
|
|
+ }
|
|
|
}
|
|
|
|
|
|
static void g4x_init_clock_gating(struct drm_device *dev)
|
|
@@ -7820,6 +7891,7 @@ static void ibx_init_clock_gating(struct drm_device *dev)
|
|
|
static void cpt_init_clock_gating(struct drm_device *dev)
|
|
|
{
|
|
|
struct drm_i915_private *dev_priv = dev->dev_private;
|
|
|
+ int pipe;
|
|
|
|
|
|
/*
|
|
|
* On Ibex Peak and Cougar Point, we need to disable clock
|
|
@@ -7829,6 +7901,9 @@ static void cpt_init_clock_gating(struct drm_device *dev)
|
|
|
I915_WRITE(SOUTH_DSPCLK_GATE_D, PCH_DPLSUNIT_CLOCK_GATE_DISABLE);
|
|
|
I915_WRITE(SOUTH_CHICKEN2, I915_READ(SOUTH_CHICKEN2) |
|
|
|
DPLS_EDP_PPS_FIX_DIS);
|
|
|
+ /* Without this, mode sets may fail silently on FDI */
|
|
|
+ for_each_pipe(pipe)
|
|
|
+ I915_WRITE(TRANS_CHICKEN2(pipe), TRANS_AUTOTRAIN_GEN_STALL_DIS);
|
|
|
}
|
|
|
|
|
|
static void ironlake_teardown_rc6(struct drm_device *dev)
|
|
@@ -8178,6 +8253,9 @@ struct intel_quirk intel_quirks[] = {
|
|
|
|
|
|
/* Lenovo U160 cannot use SSC on LVDS */
|
|
|
{ 0x0046, 0x17aa, 0x3920, quirk_ssc_force_disable },
|
|
|
+
|
|
|
+ /* Sony Vaio Y cannot use SSC on LVDS */
|
|
|
+ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },
|
|
|
};
|
|
|
|
|
|
static void intel_init_quirks(struct drm_device *dev)
|