Browse Source

[media] xc5000: properly report i2c write failures

The logic as written would *never* actually return an error condition,
since the loop would run until the counter hit zero but the check was
for a value less than zero.

Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Devin Heitmueller 13 years ago
parent
commit
0a3dabb15e
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/media/common/tuners/xc5000.c

+ 1 - 1
drivers/media/common/tuners/xc5000.c

@@ -343,7 +343,7 @@ static int xc_write_reg(struct xc5000_priv *priv, u16 regAddr, u16 i2cData)
 			}
 		}
 	}
-	if (WatchDogTimer < 0)
+	if (WatchDogTimer <= 0)
 		result = XC_RESULT_I2C_WRITE_FAILURE;
 
 	return result;