Home Explore Help
Register Sign In
phyus
/
linux-vybrid_public
8
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

[DCCP]: Dont use dccp_v4_checksum in dccp_make_response

dccp_make_response is shared by ipv4/6 and the ipv6 code was
recalculating the checksum, not good, so move the dccp_v4_checksum
call to dccp_v4_send_response.

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Arnaldo Carvalho de Melo 19 years ago
parent
c985ed705f
commit
0a1ec676dd
2 changed files with 3 additions and 3 deletions
Split View Show Diff Stats
  1. 3 0
      net/dccp/ipv4.c
  2. 0 3
      net/dccp/output.c

+ 3 - 0
net/dccp/ipv4.c
View File 

@@ -264,7 +264,10 @@ static int dccp_v4_send_response(struct sock *sk, struct request_sock *req,
 
 	skb = dccp_make_response(sk, dst, req);
 
 	if (skb != NULL) {
 
 		const struct inet_request_sock *ireq = inet_rsk(req);
 
+		struct dccp_hdr *dh = dccp_hdr(skb);
 
 
+		dh->dccph_checksum = dccp_v4_checksum(skb, ireq->loc_addr,
 
+						      ireq->rmt_addr);
 
 		memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));
 
 		err = ip_build_and_send_pkt(skb, sk, ireq->loc_addr,
 
 					    ireq->rmt_addr,

+ 0 - 3
net/dccp/output.c
View File 

@@ -314,9 +314,6 @@ struct sk_buff *dccp_make_response(struct sock *sk, struct dst_entry *dst,
 
 	dccp_hdr_set_ack(dccp_hdr_ack_bits(skb), dreq->dreq_isr);
 
 	dccp_hdr_response(skb)->dccph_resp_service = dreq->dreq_service;
 
 
-	dh->dccph_checksum = dccp_v4_checksum(skb, inet_rsk(req)->loc_addr,
 
-					      inet_rsk(req)->rmt_addr);
 
-
 
 	DCCP_INC_STATS(DCCP_MIB_OUTSEGS);
 
 	return skb;
 
 }