浏览代码

mtd: OneNAND: Fix test of unsigned in onenand_otp_walk()

mtd->writesize and len are unsigned so the test does not work.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Roel Kluin 15 年之前
父节点
当前提交
0a032a4df6
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/mtd/onenand/onenand_base.c

+ 2 - 2
drivers/mtd/onenand/onenand_base.c

@@ -3165,10 +3165,10 @@ static int onenand_otp_walk(struct mtd_info *mtd, loff_t from, size_t len,
 
 	/* Check User/Factory boundary */
 	if (mode == MTD_OTP_USER) {
-		if (((mtd->writesize * otp_pages) - (from + len)) < 0)
+		if (mtd->writesize * otp_pages < from + len)
 			return 0;
 	} else {
-		if (((mtd->writesize * otp_pages) - len) < 0)
+		if (mtd->writesize * otp_pages <  len)
 			return 0;
 	}