Explorar o código

pata_it8213: fix wrong PIO timings being programmed

* do not clear PIO timings for master when programming slave
* program new PIO timings in the correct register nibble

Both changes should be safe as this is how we have been doing
things in IDE it8213 host driver for years.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Bartlomiej Zolnierkiewicz %!s(int64=15) %!d(string=hai) anos
pai
achega
088ccb53a3
Modificáronse 1 ficheiros con 2 adicións e 2 borrados
  1. 2 2
      drivers/ata/pata_it8213.c

+ 2 - 2
drivers/ata/pata_it8213.c

@@ -112,13 +112,13 @@ static void it8213_set_piomode (struct ata_port *ap, struct ata_device *adev)
 	} else {
 	} else {
 		u8 slave_data;
 		u8 slave_data;
 
 
-		idetm_data &= 0xCC0F;
+		idetm_data &= 0xFF0F;
 		idetm_data |= (control << 4);
 		idetm_data |= (control << 4);
 
 
 		/* Slave timing in separate register */
 		/* Slave timing in separate register */
 		pci_read_config_byte(dev, 0x44, &slave_data);
 		pci_read_config_byte(dev, 0x44, &slave_data);
 		slave_data &= 0xF0;
 		slave_data &= 0xF0;
-		slave_data |= ((timings[pio][0] << 2) | timings[pio][1]) << 4;
+		slave_data |= (timings[pio][0] << 2) | timings[pio][1];
 		pci_write_config_byte(dev, 0x44, slave_data);
 		pci_write_config_byte(dev, 0x44, slave_data);
 	}
 	}