瀏覽代碼

GPIO: OMAP: fix setting IRQWAKEN bits for OMAP4

Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits,
causing only the last bit set to take effect, resulting in lost
wakeups when the GPIO controller is in idle.

Replace direct writes to IRQWAKEN with MOD_REG_BIT calls to
perform a read-modify-write on the register.

Signed-off-by: Colin Cross <ccross@android.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
Colin Cross 14 年之前
父節點
當前提交
0622b25bf0
共有 1 個文件被更改,包括 2 次插入10 次删除
  1. 2 10
      drivers/gpio/gpio-omap.c

+ 2 - 10
drivers/gpio/gpio-omap.c

@@ -432,7 +432,6 @@ static inline void set_24xx_gpio_triggering(struct gpio_bank *bank, int gpio,
 {
 {
 	void __iomem *base = bank->base;
 	void __iomem *base = bank->base;
 	u32 gpio_bit = 1 << gpio;
 	u32 gpio_bit = 1 << gpio;
-	u32 val;
 
 
 	if (cpu_is_omap44xx()) {
 	if (cpu_is_omap44xx()) {
 		MOD_REG_BIT(OMAP4_GPIO_LEVELDETECT0, gpio_bit,
 		MOD_REG_BIT(OMAP4_GPIO_LEVELDETECT0, gpio_bit,
@@ -455,15 +454,8 @@ static inline void set_24xx_gpio_triggering(struct gpio_bank *bank, int gpio,
 	}
 	}
 	if (likely(!(bank->non_wakeup_gpios & gpio_bit))) {
 	if (likely(!(bank->non_wakeup_gpios & gpio_bit))) {
 		if (cpu_is_omap44xx()) {
 		if (cpu_is_omap44xx()) {
-			if (trigger != 0)
-				__raw_writel(1 << gpio, bank->base+
-						OMAP4_GPIO_IRQWAKEN0);
-			else {
-				val = __raw_readl(bank->base +
-							OMAP4_GPIO_IRQWAKEN0);
-				__raw_writel(val & (~(1 << gpio)), bank->base +
-							 OMAP4_GPIO_IRQWAKEN0);
-			}
+			MOD_REG_BIT(OMAP4_GPIO_IRQWAKEN0, gpio_bit,
+				trigger != 0);
 		} else {
 		} else {
 			/*
 			/*
 			 * GPIO wakeup request can only be generated on edge
 			 * GPIO wakeup request can only be generated on edge