Explorar o código

dmaengine: struct device - replace bus_id with dev_name(), dev_set_name()

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Kay Sievers %!s(int64=16) %!d(string=hai) anos
pai
achega
06190d8415
Modificáronse 2 ficheiros con 13 adicións e 13 borrados
  1. 2 2
      drivers/dma/dmaengine.c
  2. 11 11
      drivers/dma/dmatest.c

+ 2 - 2
drivers/dma/dmaengine.c

@@ -399,8 +399,8 @@ int dma_async_device_register(struct dma_device *device)
 		chan->chan_id = chancnt++;
 		chan->chan_id = chancnt++;
 		chan->dev.class = &dma_devclass;
 		chan->dev.class = &dma_devclass;
 		chan->dev.parent = device->dev;
 		chan->dev.parent = device->dev;
-		snprintf(chan->dev.bus_id, BUS_ID_SIZE, "dma%dchan%d",
-		         device->dev_id, chan->chan_id);
+		dev_set_name(&chan->dev, "dma%dchan%d",
+			     device->dev_id, chan->chan_id);
 
 
 		rc = device_register(&chan->dev);
 		rc = device_register(&chan->dev);
 		if (rc) {
 		if (rc) {

+ 11 - 11
drivers/dma/dmatest.c

@@ -20,11 +20,11 @@ static unsigned int test_buf_size = 16384;
 module_param(test_buf_size, uint, S_IRUGO);
 module_param(test_buf_size, uint, S_IRUGO);
 MODULE_PARM_DESC(test_buf_size, "Size of the memcpy test buffer");
 MODULE_PARM_DESC(test_buf_size, "Size of the memcpy test buffer");
 
 
-static char test_channel[BUS_ID_SIZE];
+static char test_channel[20];
 module_param_string(channel, test_channel, sizeof(test_channel), S_IRUGO);
 module_param_string(channel, test_channel, sizeof(test_channel), S_IRUGO);
 MODULE_PARM_DESC(channel, "Bus ID of the channel to test (default: any)");
 MODULE_PARM_DESC(channel, "Bus ID of the channel to test (default: any)");
 
 
-static char test_device[BUS_ID_SIZE];
+static char test_device[20];
 module_param_string(device, test_device, sizeof(test_device), S_IRUGO);
 module_param_string(device, test_device, sizeof(test_device), S_IRUGO);
 MODULE_PARM_DESC(device, "Bus ID of the DMA Engine to test (default: any)");
 MODULE_PARM_DESC(device, "Bus ID of the DMA Engine to test (default: any)");
 
 
@@ -80,14 +80,14 @@ static bool dmatest_match_channel(struct dma_chan *chan)
 {
 {
 	if (test_channel[0] == '\0')
 	if (test_channel[0] == '\0')
 		return true;
 		return true;
-	return strcmp(chan->dev.bus_id, test_channel) == 0;
+	return strcmp(dev_name(&chan->dev), test_channel) == 0;
 }
 }
 
 
 static bool dmatest_match_device(struct dma_device *device)
 static bool dmatest_match_device(struct dma_device *device)
 {
 {
 	if (test_device[0] == '\0')
 	if (test_device[0] == '\0')
 		return true;
 		return true;
-	return strcmp(device->dev->bus_id, test_device) == 0;
+	return strcmp(dev_name(device->dev), test_device) == 0;
 }
 }
 
 
 static unsigned long dmatest_random(void)
 static unsigned long dmatest_random(void)
@@ -332,7 +332,7 @@ static enum dma_state_client dmatest_add_channel(struct dma_chan *chan)
 
 
 	dtc = kmalloc(sizeof(struct dmatest_chan), GFP_KERNEL);
 	dtc = kmalloc(sizeof(struct dmatest_chan), GFP_KERNEL);
 	if (!dtc) {
 	if (!dtc) {
-		pr_warning("dmatest: No memory for %s\n", chan->dev.bus_id);
+		pr_warning("dmatest: No memory for %s\n", dev_name(&chan->dev));
 		return DMA_NAK;
 		return DMA_NAK;
 	}
 	}
 
 
@@ -343,16 +343,16 @@ static enum dma_state_client dmatest_add_channel(struct dma_chan *chan)
 		thread = kzalloc(sizeof(struct dmatest_thread), GFP_KERNEL);
 		thread = kzalloc(sizeof(struct dmatest_thread), GFP_KERNEL);
 		if (!thread) {
 		if (!thread) {
 			pr_warning("dmatest: No memory for %s-test%u\n",
 			pr_warning("dmatest: No memory for %s-test%u\n",
-					chan->dev.bus_id, i);
+				   dev_name(&chan->dev), i);
 			break;
 			break;
 		}
 		}
 		thread->chan = dtc->chan;
 		thread->chan = dtc->chan;
 		smp_wmb();
 		smp_wmb();
 		thread->task = kthread_run(dmatest_func, thread, "%s-test%u",
 		thread->task = kthread_run(dmatest_func, thread, "%s-test%u",
-				chan->dev.bus_id, i);
+				dev_name(&chan->dev), i);
 		if (IS_ERR(thread->task)) {
 		if (IS_ERR(thread->task)) {
 			pr_warning("dmatest: Failed to run thread %s-test%u\n",
 			pr_warning("dmatest: Failed to run thread %s-test%u\n",
-					chan->dev.bus_id, i);
+					dev_name(&chan->dev), i);
 			kfree(thread);
 			kfree(thread);
 			break;
 			break;
 		}
 		}
@@ -362,7 +362,7 @@ static enum dma_state_client dmatest_add_channel(struct dma_chan *chan)
 		list_add_tail(&thread->node, &dtc->threads);
 		list_add_tail(&thread->node, &dtc->threads);
 	}
 	}
 
 
-	pr_info("dmatest: Started %u threads using %s\n", i, chan->dev.bus_id);
+	pr_info("dmatest: Started %u threads using %s\n", i, dev_name(&chan->dev));
 
 
 	list_add_tail(&dtc->node, &dmatest_channels);
 	list_add_tail(&dtc->node, &dmatest_channels);
 	nr_channels++;
 	nr_channels++;
@@ -379,7 +379,7 @@ static enum dma_state_client dmatest_remove_channel(struct dma_chan *chan)
 			list_del(&dtc->node);
 			list_del(&dtc->node);
 			dmatest_cleanup_channel(dtc);
 			dmatest_cleanup_channel(dtc);
 			pr_debug("dmatest: lost channel %s\n",
 			pr_debug("dmatest: lost channel %s\n",
-					chan->dev.bus_id);
+					dev_name(&chan->dev));
 			return DMA_ACK;
 			return DMA_ACK;
 		}
 		}
 	}
 	}
@@ -418,7 +418,7 @@ dmatest_event(struct dma_client *client, struct dma_chan *chan,
 
 
 	default:
 	default:
 		pr_info("dmatest: Unhandled event %u (%s)\n",
 		pr_info("dmatest: Unhandled event %u (%s)\n",
-				state, chan->dev.bus_id);
+				state, dev_name(&chan->dev));
 		break;
 		break;
 	}
 	}