Explorar o código

efivars: memory leak on error in create_efivars_bin_attributes()

This is a cut and paste bug.  We intended to free ->del_var and
->new_var but we only free ->new_var.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Mike Waychison <mikew@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter %!s(int64=14) %!d(string=hai) anos
pai
achega
051d51bc6a
Modificáronse 1 ficheiros con 2 adicións e 2 borrados
  1. 2 2
      drivers/firmware/efivars.c

+ 2 - 2
drivers/firmware/efivars.c

@@ -677,8 +677,8 @@ create_efivars_bin_attributes(struct efivars *efivars)
 
 	return 0;
 out_free:
-	kfree(efivars->new_var);
-	efivars->new_var = NULL;
+	kfree(efivars->del_var);
+	efivars->del_var = NULL;
 	kfree(efivars->new_var);
 	efivars->new_var = NULL;
 	return error;