Browse Source

call_usermodehelper: UMH_WAIT_EXEC ignores kernel_thread() failure

UMH_WAIT_EXEC should report the error if kernel_thread() fails, like
UMH_WAIT_PROC does.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Oleg Nesterov 15 years ago
parent
commit
04b1c384fb
1 changed files with 2 additions and 2 deletions
  1. 2 2
      kernel/kmod.c

+ 2 - 2
kernel/kmod.c

@@ -235,10 +235,10 @@ static void __call_usermodehelper(struct work_struct *work)
 	case UMH_WAIT_PROC:
 	case UMH_WAIT_PROC:
 		if (pid > 0)
 		if (pid > 0)
 			break;
 			break;
-		sub_info->retval = pid;
 		/* FALLTHROUGH */
 		/* FALLTHROUGH */
-
 	case UMH_WAIT_EXEC:
 	case UMH_WAIT_EXEC:
+		if (pid < 0)
+			sub_info->retval = pid;
 		complete(sub_info->complete);
 		complete(sub_info->complete);
 	}
 	}
 }
 }