Browse Source

ocfs2: potential ERR_PTR dereference on error paths

If "handle" is non null at the end of the function then we assume it's a
valid pointer and pass it to ocfs2_commit_trans();

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: <stable@kernel.org>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Dan Carpenter 15 years ago
parent
commit
0350cb078f
1 changed files with 1 additions and 0 deletions
  1. 1 0
      fs/ocfs2/inode.c

+ 1 - 0
fs/ocfs2/inode.c

@@ -559,6 +559,7 @@ static int ocfs2_truncate_for_delete(struct ocfs2_super *osb,
 		handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
 		handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
 		if (IS_ERR(handle)) {
 		if (IS_ERR(handle)) {
 			status = PTR_ERR(handle);
 			status = PTR_ERR(handle);
+			handle = NULL;
 			mlog_errno(status);
 			mlog_errno(status);
 			goto out;
 			goto out;
 		}
 		}