Browse Source

9p: fix bad error path in conversion routines

When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err))
and it will not be happy about it.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Mariusz Kozlowski 17 years ago
parent
commit
02881d9478
1 changed files with 1 additions and 0 deletions
  1. 1 0
      net/9p/conv.c

+ 1 - 0
net/9p/conv.c

@@ -796,6 +796,7 @@ struct p9_fcall *p9_create_twrite_u(u32 fid, u64 offset, u32 count,
 	if (err) {
 	if (err) {
 		kfree(fc);
 		kfree(fc);
 		fc = ERR_PTR(err);
 		fc = ERR_PTR(err);
+		goto error;
 	}
 	}
 
 
 	if (buf_check_overflow(bufp)) {
 	if (buf_check_overflow(bufp)) {