浏览代码

[CPUFREQ] check sysfs_create_link return value

Trivial patch to check sysfs_create_link return values.
Fail gracefully if needed.

Signed-off-by: Ahmed Darwish <darwish.07@gmail.com>
Signed-off-by: Dave Jones <davej@redhat.com>
Ahmed S. Darwish 18 年之前
父节点
当前提交
0142f9dce8
共有 1 个文件被更改,包括 13 次插入4 次删除
  1. 13 4
      drivers/cpufreq/cpufreq.c

+ 13 - 4
drivers/cpufreq/cpufreq.c

@@ -722,8 +722,13 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
 			spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
 			spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
 
 
 			dprintk("CPU already managed, adding link\n");
 			dprintk("CPU already managed, adding link\n");
-			sysfs_create_link(&sys_dev->kobj,
-					  &managed_policy->kobj, "cpufreq");
+			ret = sysfs_create_link(&sys_dev->kobj,
+						&managed_policy->kobj,
+						"cpufreq");
+			if (ret) {
+				mutex_unlock(&policy->lock);
+				goto err_out_driver_exit;
+			}
 
 
 			cpufreq_debug_enable_ratelimit();
 			cpufreq_debug_enable_ratelimit();
 			mutex_unlock(&policy->lock);
 			mutex_unlock(&policy->lock);
@@ -770,8 +775,12 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
 		dprintk("CPU %u already managed, adding link\n", j);
 		dprintk("CPU %u already managed, adding link\n", j);
 		cpufreq_cpu_get(cpu);
 		cpufreq_cpu_get(cpu);
 		cpu_sys_dev = get_cpu_sysdev(j);
 		cpu_sys_dev = get_cpu_sysdev(j);
-		sysfs_create_link(&cpu_sys_dev->kobj, &policy->kobj,
-				  "cpufreq");
+		ret = sysfs_create_link(&cpu_sys_dev->kobj, &policy->kobj,
+					"cpufreq");
+		if (ret) {
+			mutex_unlock(&policy->lock);
+			goto err_out_unregister;
+		}
 	}
 	}
 
 
 	policy->governor = NULL; /* to assure that the starting sequence is
 	policy->governor = NULL; /* to assure that the starting sequence is