Browse Source

ieee1394: remove superfluous assertions

hpsb_read, hpsb_write, hpsb_lock are sleeping functions which nobody is
in danger to use in atomic context.  Besides, in_interrupt does not
cover all types of atomic context.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Stefan Richter 16 năm trước cách đây
mục cha
commit
00fc3072e4

+ 0 - 6
drivers/ieee1394/ieee1394_transactions.c

@@ -501,8 +501,6 @@ int hpsb_read(struct hpsb_host *host, nodeid_t node, unsigned int generation,
 	if (length == 0)
 	if (length == 0)
 		return -EINVAL;
 		return -EINVAL;
 
 
-	BUG_ON(in_interrupt());	// We can't be called in an interrupt, yet
-
 	packet = hpsb_make_readpacket(host, node, addr, length);
 	packet = hpsb_make_readpacket(host, node, addr, length);
 
 
 	if (!packet) {
 	if (!packet) {
@@ -550,8 +548,6 @@ int hpsb_write(struct hpsb_host *host, nodeid_t node, unsigned int generation,
 	if (length == 0)
 	if (length == 0)
 		return -EINVAL;
 		return -EINVAL;
 
 
-	BUG_ON(in_interrupt());	// We can't be called in an interrupt, yet
-
 	packet = hpsb_make_writepacket(host, node, addr, buffer, length);
 	packet = hpsb_make_writepacket(host, node, addr, buffer, length);
 
 
 	if (!packet)
 	if (!packet)
@@ -577,8 +573,6 @@ int hpsb_lock(struct hpsb_host *host, nodeid_t node, unsigned int generation,
 	struct hpsb_packet *packet;
 	struct hpsb_packet *packet;
 	int retval = 0;
 	int retval = 0;
 
 
-	BUG_ON(in_interrupt());
-
 	packet = hpsb_make_lockpacket(host, node, addr, extcode, data, arg);
 	packet = hpsb_make_lockpacket(host, node, addr, extcode, data, arg);
 	if (!packet)
 	if (!packet)
 		return -ENOMEM;
 		return -ENOMEM;