|
@@ -17,6 +17,11 @@
|
|
|
|
|
|
#include <linux/scatterlist.h>
|
|
#include <linux/scatterlist.h>
|
|
#include <linux/swap.h> /* For nr_free_buffer_pages() */
|
|
#include <linux/swap.h> /* For nr_free_buffer_pages() */
|
|
|
|
+#include <linux/list.h>
|
|
|
|
+
|
|
|
|
+#include <linux/debugfs.h>
|
|
|
|
+#include <linux/uaccess.h>
|
|
|
|
+#include <linux/seq_file.h>
|
|
|
|
|
|
#define RESULT_OK 0
|
|
#define RESULT_OK 0
|
|
#define RESULT_FAIL 1
|
|
#define RESULT_FAIL 1
|
|
@@ -56,7 +61,9 @@ struct mmc_test_mem {
|
|
* struct mmc_test_area - information for performance tests.
|
|
* struct mmc_test_area - information for performance tests.
|
|
* @max_sz: test area size (in bytes)
|
|
* @max_sz: test area size (in bytes)
|
|
* @dev_addr: address on card at which to do performance tests
|
|
* @dev_addr: address on card at which to do performance tests
|
|
- * @max_segs: maximum segments in scatterlist @sg
|
|
|
|
|
|
+ * @max_tfr: maximum transfer size allowed by driver (in bytes)
|
|
|
|
+ * @max_segs: maximum segments allowed by driver in scatterlist @sg
|
|
|
|
+ * @max_seg_sz: maximum segment size allowed by driver
|
|
* @blocks: number of (512 byte) blocks currently mapped by @sg
|
|
* @blocks: number of (512 byte) blocks currently mapped by @sg
|
|
* @sg_len: length of currently mapped scatterlist @sg
|
|
* @sg_len: length of currently mapped scatterlist @sg
|
|
* @mem: allocated memory
|
|
* @mem: allocated memory
|
|
@@ -65,13 +72,59 @@ struct mmc_test_mem {
|
|
struct mmc_test_area {
|
|
struct mmc_test_area {
|
|
unsigned long max_sz;
|
|
unsigned long max_sz;
|
|
unsigned int dev_addr;
|
|
unsigned int dev_addr;
|
|
|
|
+ unsigned int max_tfr;
|
|
unsigned int max_segs;
|
|
unsigned int max_segs;
|
|
|
|
+ unsigned int max_seg_sz;
|
|
unsigned int blocks;
|
|
unsigned int blocks;
|
|
unsigned int sg_len;
|
|
unsigned int sg_len;
|
|
struct mmc_test_mem *mem;
|
|
struct mmc_test_mem *mem;
|
|
struct scatterlist *sg;
|
|
struct scatterlist *sg;
|
|
};
|
|
};
|
|
|
|
|
|
|
|
+/**
|
|
|
|
+ * struct mmc_test_transfer_result - transfer results for performance tests.
|
|
|
|
+ * @link: double-linked list
|
|
|
|
+ * @count: amount of group of sectors to check
|
|
|
|
+ * @sectors: amount of sectors to check in one group
|
|
|
|
+ * @ts: time values of transfer
|
|
|
|
+ * @rate: calculated transfer rate
|
|
|
|
+ */
|
|
|
|
+struct mmc_test_transfer_result {
|
|
|
|
+ struct list_head link;
|
|
|
|
+ unsigned int count;
|
|
|
|
+ unsigned int sectors;
|
|
|
|
+ struct timespec ts;
|
|
|
|
+ unsigned int rate;
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
+/**
|
|
|
|
+ * struct mmc_test_general_result - results for tests.
|
|
|
|
+ * @link: double-linked list
|
|
|
|
+ * @card: card under test
|
|
|
|
+ * @testcase: number of test case
|
|
|
|
+ * @result: result of test run
|
|
|
|
+ * @tr_lst: transfer measurements if any as mmc_test_transfer_result
|
|
|
|
+ */
|
|
|
|
+struct mmc_test_general_result {
|
|
|
|
+ struct list_head link;
|
|
|
|
+ struct mmc_card *card;
|
|
|
|
+ int testcase;
|
|
|
|
+ int result;
|
|
|
|
+ struct list_head tr_lst;
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
+/**
|
|
|
|
+ * struct mmc_test_dbgfs_file - debugfs related file.
|
|
|
|
+ * @link: double-linked list
|
|
|
|
+ * @card: card under test
|
|
|
|
+ * @file: file created under debugfs
|
|
|
|
+ */
|
|
|
|
+struct mmc_test_dbgfs_file {
|
|
|
|
+ struct list_head link;
|
|
|
|
+ struct mmc_card *card;
|
|
|
|
+ struct dentry *file;
|
|
|
|
+};
|
|
|
|
+
|
|
/**
|
|
/**
|
|
* struct mmc_test_card - test information.
|
|
* struct mmc_test_card - test information.
|
|
* @card: card under test
|
|
* @card: card under test
|
|
@@ -79,6 +132,7 @@ struct mmc_test_area {
|
|
* @buffer: transfer buffer
|
|
* @buffer: transfer buffer
|
|
* @highmem: buffer for highmem tests
|
|
* @highmem: buffer for highmem tests
|
|
* @area: information for performance tests
|
|
* @area: information for performance tests
|
|
|
|
+ * @gr: pointer to results of current testcase
|
|
*/
|
|
*/
|
|
struct mmc_test_card {
|
|
struct mmc_test_card {
|
|
struct mmc_card *card;
|
|
struct mmc_card *card;
|
|
@@ -88,7 +142,8 @@ struct mmc_test_card {
|
|
#ifdef CONFIG_HIGHMEM
|
|
#ifdef CONFIG_HIGHMEM
|
|
struct page *highmem;
|
|
struct page *highmem;
|
|
#endif
|
|
#endif
|
|
- struct mmc_test_area area;
|
|
|
|
|
|
+ struct mmc_test_area area;
|
|
|
|
+ struct mmc_test_general_result *gr;
|
|
};
|
|
};
|
|
|
|
|
|
/*******************************************************************/
|
|
/*******************************************************************/
|
|
@@ -100,17 +155,7 @@ struct mmc_test_card {
|
|
*/
|
|
*/
|
|
static int mmc_test_set_blksize(struct mmc_test_card *test, unsigned size)
|
|
static int mmc_test_set_blksize(struct mmc_test_card *test, unsigned size)
|
|
{
|
|
{
|
|
- struct mmc_command cmd;
|
|
|
|
- int ret;
|
|
|
|
-
|
|
|
|
- cmd.opcode = MMC_SET_BLOCKLEN;
|
|
|
|
- cmd.arg = size;
|
|
|
|
- cmd.flags = MMC_RSP_R1 | MMC_CMD_AC;
|
|
|
|
- ret = mmc_wait_for_cmd(test->card->host, &cmd, 0);
|
|
|
|
- if (ret)
|
|
|
|
- return ret;
|
|
|
|
-
|
|
|
|
- return 0;
|
|
|
|
|
|
+ return mmc_set_blocklen(test->card, size);
|
|
}
|
|
}
|
|
|
|
|
|
/*
|
|
/*
|
|
@@ -245,27 +290,38 @@ static void mmc_test_free_mem(struct mmc_test_mem *mem)
|
|
|
|
|
|
/*
|
|
/*
|
|
* Allocate a lot of memory, preferrably max_sz but at least min_sz. In case
|
|
* Allocate a lot of memory, preferrably max_sz but at least min_sz. In case
|
|
- * there isn't much memory do not exceed 1/16th total lowmem pages.
|
|
|
|
|
|
+ * there isn't much memory do not exceed 1/16th total lowmem pages. Also do
|
|
|
|
+ * not exceed a maximum number of segments and try not to make segments much
|
|
|
|
+ * bigger than maximum segment size.
|
|
*/
|
|
*/
|
|
static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz,
|
|
static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz,
|
|
- unsigned long max_sz)
|
|
|
|
|
|
+ unsigned long max_sz,
|
|
|
|
+ unsigned int max_segs,
|
|
|
|
+ unsigned int max_seg_sz)
|
|
{
|
|
{
|
|
unsigned long max_page_cnt = DIV_ROUND_UP(max_sz, PAGE_SIZE);
|
|
unsigned long max_page_cnt = DIV_ROUND_UP(max_sz, PAGE_SIZE);
|
|
unsigned long min_page_cnt = DIV_ROUND_UP(min_sz, PAGE_SIZE);
|
|
unsigned long min_page_cnt = DIV_ROUND_UP(min_sz, PAGE_SIZE);
|
|
|
|
+ unsigned long max_seg_page_cnt = DIV_ROUND_UP(max_seg_sz, PAGE_SIZE);
|
|
unsigned long page_cnt = 0;
|
|
unsigned long page_cnt = 0;
|
|
unsigned long limit = nr_free_buffer_pages() >> 4;
|
|
unsigned long limit = nr_free_buffer_pages() >> 4;
|
|
struct mmc_test_mem *mem;
|
|
struct mmc_test_mem *mem;
|
|
|
|
|
|
if (max_page_cnt > limit)
|
|
if (max_page_cnt > limit)
|
|
max_page_cnt = limit;
|
|
max_page_cnt = limit;
|
|
- if (max_page_cnt < min_page_cnt)
|
|
|
|
- max_page_cnt = min_page_cnt;
|
|
|
|
|
|
+ if (min_page_cnt > max_page_cnt)
|
|
|
|
+ min_page_cnt = max_page_cnt;
|
|
|
|
+
|
|
|
|
+ if (max_seg_page_cnt > max_page_cnt)
|
|
|
|
+ max_seg_page_cnt = max_page_cnt;
|
|
|
|
+
|
|
|
|
+ if (max_segs > max_page_cnt)
|
|
|
|
+ max_segs = max_page_cnt;
|
|
|
|
|
|
mem = kzalloc(sizeof(struct mmc_test_mem), GFP_KERNEL);
|
|
mem = kzalloc(sizeof(struct mmc_test_mem), GFP_KERNEL);
|
|
if (!mem)
|
|
if (!mem)
|
|
return NULL;
|
|
return NULL;
|
|
|
|
|
|
- mem->arr = kzalloc(sizeof(struct mmc_test_pages) * max_page_cnt,
|
|
|
|
|
|
+ mem->arr = kzalloc(sizeof(struct mmc_test_pages) * max_segs,
|
|
GFP_KERNEL);
|
|
GFP_KERNEL);
|
|
if (!mem->arr)
|
|
if (!mem->arr)
|
|
goto out_free;
|
|
goto out_free;
|
|
@@ -276,7 +332,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz,
|
|
gfp_t flags = GFP_KERNEL | GFP_DMA | __GFP_NOWARN |
|
|
gfp_t flags = GFP_KERNEL | GFP_DMA | __GFP_NOWARN |
|
|
__GFP_NORETRY;
|
|
__GFP_NORETRY;
|
|
|
|
|
|
- order = get_order(max_page_cnt << PAGE_SHIFT);
|
|
|
|
|
|
+ order = get_order(max_seg_page_cnt << PAGE_SHIFT);
|
|
while (1) {
|
|
while (1) {
|
|
page = alloc_pages(flags, order);
|
|
page = alloc_pages(flags, order);
|
|
if (page || !order)
|
|
if (page || !order)
|
|
@@ -295,6 +351,11 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz,
|
|
break;
|
|
break;
|
|
max_page_cnt -= 1UL << order;
|
|
max_page_cnt -= 1UL << order;
|
|
page_cnt += 1UL << order;
|
|
page_cnt += 1UL << order;
|
|
|
|
+ if (mem->cnt >= max_segs) {
|
|
|
|
+ if (page_cnt < min_page_cnt)
|
|
|
|
+ goto out_free;
|
|
|
|
+ break;
|
|
|
|
+ }
|
|
}
|
|
}
|
|
|
|
|
|
return mem;
|
|
return mem;
|
|
@@ -310,7 +371,8 @@ out_free:
|
|
*/
|
|
*/
|
|
static int mmc_test_map_sg(struct mmc_test_mem *mem, unsigned long sz,
|
|
static int mmc_test_map_sg(struct mmc_test_mem *mem, unsigned long sz,
|
|
struct scatterlist *sglist, int repeat,
|
|
struct scatterlist *sglist, int repeat,
|
|
- unsigned int max_segs, unsigned int *sg_len)
|
|
|
|
|
|
+ unsigned int max_segs, unsigned int max_seg_sz,
|
|
|
|
+ unsigned int *sg_len)
|
|
{
|
|
{
|
|
struct scatterlist *sg = NULL;
|
|
struct scatterlist *sg = NULL;
|
|
unsigned int i;
|
|
unsigned int i;
|
|
@@ -322,8 +384,10 @@ static int mmc_test_map_sg(struct mmc_test_mem *mem, unsigned long sz,
|
|
for (i = 0; i < mem->cnt; i++) {
|
|
for (i = 0; i < mem->cnt; i++) {
|
|
unsigned long len = PAGE_SIZE << mem->arr[i].order;
|
|
unsigned long len = PAGE_SIZE << mem->arr[i].order;
|
|
|
|
|
|
- if (sz < len)
|
|
|
|
|
|
+ if (len > sz)
|
|
len = sz;
|
|
len = sz;
|
|
|
|
+ if (len > max_seg_sz)
|
|
|
|
+ len = max_seg_sz;
|
|
if (sg)
|
|
if (sg)
|
|
sg = sg_next(sg);
|
|
sg = sg_next(sg);
|
|
else
|
|
else
|
|
@@ -355,6 +419,7 @@ static int mmc_test_map_sg_max_scatter(struct mmc_test_mem *mem,
|
|
unsigned long sz,
|
|
unsigned long sz,
|
|
struct scatterlist *sglist,
|
|
struct scatterlist *sglist,
|
|
unsigned int max_segs,
|
|
unsigned int max_segs,
|
|
|
|
+ unsigned int max_seg_sz,
|
|
unsigned int *sg_len)
|
|
unsigned int *sg_len)
|
|
{
|
|
{
|
|
struct scatterlist *sg = NULL;
|
|
struct scatterlist *sg = NULL;
|
|
@@ -365,7 +430,7 @@ static int mmc_test_map_sg_max_scatter(struct mmc_test_mem *mem,
|
|
sg_init_table(sglist, max_segs);
|
|
sg_init_table(sglist, max_segs);
|
|
|
|
|
|
*sg_len = 0;
|
|
*sg_len = 0;
|
|
- while (sz && i) {
|
|
|
|
|
|
+ while (sz) {
|
|
base = page_address(mem->arr[--i].page);
|
|
base = page_address(mem->arr[--i].page);
|
|
cnt = 1 << mem->arr[i].order;
|
|
cnt = 1 << mem->arr[i].order;
|
|
while (sz && cnt) {
|
|
while (sz && cnt) {
|
|
@@ -374,7 +439,9 @@ static int mmc_test_map_sg_max_scatter(struct mmc_test_mem *mem,
|
|
continue;
|
|
continue;
|
|
last_addr = addr;
|
|
last_addr = addr;
|
|
len = PAGE_SIZE;
|
|
len = PAGE_SIZE;
|
|
- if (sz < len)
|
|
|
|
|
|
+ if (len > max_seg_sz)
|
|
|
|
+ len = max_seg_sz;
|
|
|
|
+ if (len > sz)
|
|
len = sz;
|
|
len = sz;
|
|
if (sg)
|
|
if (sg)
|
|
sg = sg_next(sg);
|
|
sg = sg_next(sg);
|
|
@@ -386,6 +453,8 @@ static int mmc_test_map_sg_max_scatter(struct mmc_test_mem *mem,
|
|
sz -= len;
|
|
sz -= len;
|
|
*sg_len += 1;
|
|
*sg_len += 1;
|
|
}
|
|
}
|
|
|
|
+ if (i == 0)
|
|
|
|
+ i = mem->cnt;
|
|
}
|
|
}
|
|
|
|
|
|
if (sg)
|
|
if (sg)
|
|
@@ -420,6 +489,30 @@ static unsigned int mmc_test_rate(uint64_t bytes, struct timespec *ts)
|
|
return bytes;
|
|
return bytes;
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+/*
|
|
|
|
+ * Save transfer results for future usage
|
|
|
|
+ */
|
|
|
|
+static void mmc_test_save_transfer_result(struct mmc_test_card *test,
|
|
|
|
+ unsigned int count, unsigned int sectors, struct timespec ts,
|
|
|
|
+ unsigned int rate)
|
|
|
|
+{
|
|
|
|
+ struct mmc_test_transfer_result *tr;
|
|
|
|
+
|
|
|
|
+ if (!test->gr)
|
|
|
|
+ return;
|
|
|
|
+
|
|
|
|
+ tr = kmalloc(sizeof(struct mmc_test_transfer_result), GFP_KERNEL);
|
|
|
|
+ if (!tr)
|
|
|
|
+ return;
|
|
|
|
+
|
|
|
|
+ tr->count = count;
|
|
|
|
+ tr->sectors = sectors;
|
|
|
|
+ tr->ts = ts;
|
|
|
|
+ tr->rate = rate;
|
|
|
|
+
|
|
|
|
+ list_add_tail(&tr->link, &test->gr->tr_lst);
|
|
|
|
+}
|
|
|
|
+
|
|
/*
|
|
/*
|
|
* Print the transfer rate.
|
|
* Print the transfer rate.
|
|
*/
|
|
*/
|
|
@@ -436,8 +529,10 @@ static void mmc_test_print_rate(struct mmc_test_card *test, uint64_t bytes,
|
|
printk(KERN_INFO "%s: Transfer of %u sectors (%u%s KiB) took %lu.%09lu "
|
|
printk(KERN_INFO "%s: Transfer of %u sectors (%u%s KiB) took %lu.%09lu "
|
|
"seconds (%u kB/s, %u KiB/s)\n",
|
|
"seconds (%u kB/s, %u KiB/s)\n",
|
|
mmc_hostname(test->card->host), sectors, sectors >> 1,
|
|
mmc_hostname(test->card->host), sectors, sectors >> 1,
|
|
- (sectors == 1 ? ".5" : ""), (unsigned long)ts.tv_sec,
|
|
|
|
|
|
+ (sectors & 1 ? ".5" : ""), (unsigned long)ts.tv_sec,
|
|
(unsigned long)ts.tv_nsec, rate / 1000, rate / 1024);
|
|
(unsigned long)ts.tv_nsec, rate / 1000, rate / 1024);
|
|
|
|
+
|
|
|
|
+ mmc_test_save_transfer_result(test, 1, sectors, ts, rate);
|
|
}
|
|
}
|
|
|
|
|
|
/*
|
|
/*
|
|
@@ -458,9 +553,11 @@ static void mmc_test_print_avg_rate(struct mmc_test_card *test, uint64_t bytes,
|
|
printk(KERN_INFO "%s: Transfer of %u x %u sectors (%u x %u%s KiB) took "
|
|
printk(KERN_INFO "%s: Transfer of %u x %u sectors (%u x %u%s KiB) took "
|
|
"%lu.%09lu seconds (%u kB/s, %u KiB/s)\n",
|
|
"%lu.%09lu seconds (%u kB/s, %u KiB/s)\n",
|
|
mmc_hostname(test->card->host), count, sectors, count,
|
|
mmc_hostname(test->card->host), count, sectors, count,
|
|
- sectors >> 1, (sectors == 1 ? ".5" : ""),
|
|
|
|
|
|
+ sectors >> 1, (sectors & 1 ? ".5" : ""),
|
|
(unsigned long)ts.tv_sec, (unsigned long)ts.tv_nsec,
|
|
(unsigned long)ts.tv_sec, (unsigned long)ts.tv_nsec,
|
|
rate / 1000, rate / 1024);
|
|
rate / 1000, rate / 1024);
|
|
|
|
+
|
|
|
|
+ mmc_test_save_transfer_result(test, count, sectors, ts, rate);
|
|
}
|
|
}
|
|
|
|
|
|
/*
|
|
/*
|
|
@@ -1215,16 +1312,22 @@ static int mmc_test_area_map(struct mmc_test_card *test, unsigned long sz,
|
|
int max_scatter)
|
|
int max_scatter)
|
|
{
|
|
{
|
|
struct mmc_test_area *t = &test->area;
|
|
struct mmc_test_area *t = &test->area;
|
|
|
|
+ int err;
|
|
|
|
|
|
t->blocks = sz >> 9;
|
|
t->blocks = sz >> 9;
|
|
|
|
|
|
if (max_scatter) {
|
|
if (max_scatter) {
|
|
- return mmc_test_map_sg_max_scatter(t->mem, sz, t->sg,
|
|
|
|
- t->max_segs, &t->sg_len);
|
|
|
|
- } else {
|
|
|
|
- return mmc_test_map_sg(t->mem, sz, t->sg, 1, t->max_segs,
|
|
|
|
|
|
+ err = mmc_test_map_sg_max_scatter(t->mem, sz, t->sg,
|
|
|
|
+ t->max_segs, t->max_seg_sz,
|
|
&t->sg_len);
|
|
&t->sg_len);
|
|
|
|
+ } else {
|
|
|
|
+ err = mmc_test_map_sg(t->mem, sz, t->sg, 1, t->max_segs,
|
|
|
|
+ t->max_seg_sz, &t->sg_len);
|
|
}
|
|
}
|
|
|
|
+ if (err)
|
|
|
|
+ printk(KERN_INFO "%s: Failed to map sg list\n",
|
|
|
|
+ mmc_hostname(test->card->host));
|
|
|
|
+ return err;
|
|
}
|
|
}
|
|
|
|
|
|
/*
|
|
/*
|
|
@@ -1249,6 +1352,22 @@ static int mmc_test_area_io(struct mmc_test_card *test, unsigned long sz,
|
|
struct timespec ts1, ts2;
|
|
struct timespec ts1, ts2;
|
|
int ret;
|
|
int ret;
|
|
|
|
|
|
|
|
+ /*
|
|
|
|
+ * In the case of a maximally scattered transfer, the maximum transfer
|
|
|
|
+ * size is further limited by using PAGE_SIZE segments.
|
|
|
|
+ */
|
|
|
|
+ if (max_scatter) {
|
|
|
|
+ struct mmc_test_area *t = &test->area;
|
|
|
|
+ unsigned long max_tfr;
|
|
|
|
+
|
|
|
|
+ if (t->max_seg_sz >= PAGE_SIZE)
|
|
|
|
+ max_tfr = t->max_segs * PAGE_SIZE;
|
|
|
|
+ else
|
|
|
|
+ max_tfr = t->max_segs * t->max_seg_sz;
|
|
|
|
+ if (sz > max_tfr)
|
|
|
|
+ sz = max_tfr;
|
|
|
|
+ }
|
|
|
|
+
|
|
ret = mmc_test_area_map(test, sz, max_scatter);
|
|
ret = mmc_test_area_map(test, sz, max_scatter);
|
|
if (ret)
|
|
if (ret)
|
|
return ret;
|
|
return ret;
|
|
@@ -1274,7 +1393,7 @@ static int mmc_test_area_io(struct mmc_test_card *test, unsigned long sz,
|
|
*/
|
|
*/
|
|
static int mmc_test_area_fill(struct mmc_test_card *test)
|
|
static int mmc_test_area_fill(struct mmc_test_card *test)
|
|
{
|
|
{
|
|
- return mmc_test_area_io(test, test->area.max_sz, test->area.dev_addr,
|
|
|
|
|
|
+ return mmc_test_area_io(test, test->area.max_tfr, test->area.dev_addr,
|
|
1, 0, 0);
|
|
1, 0, 0);
|
|
}
|
|
}
|
|
|
|
|
|
@@ -1328,16 +1447,29 @@ static int mmc_test_area_init(struct mmc_test_card *test, int erase, int fill)
|
|
t->max_sz = TEST_AREA_MAX_SIZE;
|
|
t->max_sz = TEST_AREA_MAX_SIZE;
|
|
else
|
|
else
|
|
t->max_sz = (unsigned long)test->card->pref_erase << 9;
|
|
t->max_sz = (unsigned long)test->card->pref_erase << 9;
|
|
|
|
+
|
|
|
|
+ t->max_segs = test->card->host->max_segs;
|
|
|
|
+ t->max_seg_sz = test->card->host->max_seg_size;
|
|
|
|
+
|
|
|
|
+ t->max_tfr = t->max_sz;
|
|
|
|
+ if (t->max_tfr >> 9 > test->card->host->max_blk_count)
|
|
|
|
+ t->max_tfr = test->card->host->max_blk_count << 9;
|
|
|
|
+ if (t->max_tfr > test->card->host->max_req_size)
|
|
|
|
+ t->max_tfr = test->card->host->max_req_size;
|
|
|
|
+ if (t->max_tfr / t->max_seg_sz > t->max_segs)
|
|
|
|
+ t->max_tfr = t->max_segs * t->max_seg_sz;
|
|
|
|
+
|
|
/*
|
|
/*
|
|
- * Try to allocate enough memory for the whole area. Less is OK
|
|
|
|
|
|
+ * Try to allocate enough memory for a max. sized transfer. Less is OK
|
|
* because the same memory can be mapped into the scatterlist more than
|
|
* because the same memory can be mapped into the scatterlist more than
|
|
- * once.
|
|
|
|
|
|
+ * once. Also, take into account the limits imposed on scatterlist
|
|
|
|
+ * segments by the host driver.
|
|
*/
|
|
*/
|
|
- t->mem = mmc_test_alloc_mem(min_sz, t->max_sz);
|
|
|
|
|
|
+ t->mem = mmc_test_alloc_mem(min_sz, t->max_tfr, t->max_segs,
|
|
|
|
+ t->max_seg_sz);
|
|
if (!t->mem)
|
|
if (!t->mem)
|
|
return -ENOMEM;
|
|
return -ENOMEM;
|
|
|
|
|
|
- t->max_segs = DIV_ROUND_UP(t->max_sz, PAGE_SIZE);
|
|
|
|
t->sg = kmalloc(sizeof(struct scatterlist) * t->max_segs, GFP_KERNEL);
|
|
t->sg = kmalloc(sizeof(struct scatterlist) * t->max_segs, GFP_KERNEL);
|
|
if (!t->sg) {
|
|
if (!t->sg) {
|
|
ret = -ENOMEM;
|
|
ret = -ENOMEM;
|
|
@@ -1401,7 +1533,7 @@ static int mmc_test_area_prepare_fill(struct mmc_test_card *test)
|
|
static int mmc_test_best_performance(struct mmc_test_card *test, int write,
|
|
static int mmc_test_best_performance(struct mmc_test_card *test, int write,
|
|
int max_scatter)
|
|
int max_scatter)
|
|
{
|
|
{
|
|
- return mmc_test_area_io(test, test->area.max_sz, test->area.dev_addr,
|
|
|
|
|
|
+ return mmc_test_area_io(test, test->area.max_tfr, test->area.dev_addr,
|
|
write, max_scatter, 1);
|
|
write, max_scatter, 1);
|
|
}
|
|
}
|
|
|
|
|
|
@@ -1446,12 +1578,13 @@ static int mmc_test_profile_read_perf(struct mmc_test_card *test)
|
|
unsigned int dev_addr;
|
|
unsigned int dev_addr;
|
|
int ret;
|
|
int ret;
|
|
|
|
|
|
- for (sz = 512; sz < test->area.max_sz; sz <<= 1) {
|
|
|
|
|
|
+ for (sz = 512; sz < test->area.max_tfr; sz <<= 1) {
|
|
dev_addr = test->area.dev_addr + (sz >> 9);
|
|
dev_addr = test->area.dev_addr + (sz >> 9);
|
|
ret = mmc_test_area_io(test, sz, dev_addr, 0, 0, 1);
|
|
ret = mmc_test_area_io(test, sz, dev_addr, 0, 0, 1);
|
|
if (ret)
|
|
if (ret)
|
|
return ret;
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
+ sz = test->area.max_tfr;
|
|
dev_addr = test->area.dev_addr;
|
|
dev_addr = test->area.dev_addr;
|
|
return mmc_test_area_io(test, sz, dev_addr, 0, 0, 1);
|
|
return mmc_test_area_io(test, sz, dev_addr, 0, 0, 1);
|
|
}
|
|
}
|
|
@@ -1468,7 +1601,7 @@ static int mmc_test_profile_write_perf(struct mmc_test_card *test)
|
|
ret = mmc_test_area_erase(test);
|
|
ret = mmc_test_area_erase(test);
|
|
if (ret)
|
|
if (ret)
|
|
return ret;
|
|
return ret;
|
|
- for (sz = 512; sz < test->area.max_sz; sz <<= 1) {
|
|
|
|
|
|
+ for (sz = 512; sz < test->area.max_tfr; sz <<= 1) {
|
|
dev_addr = test->area.dev_addr + (sz >> 9);
|
|
dev_addr = test->area.dev_addr + (sz >> 9);
|
|
ret = mmc_test_area_io(test, sz, dev_addr, 1, 0, 1);
|
|
ret = mmc_test_area_io(test, sz, dev_addr, 1, 0, 1);
|
|
if (ret)
|
|
if (ret)
|
|
@@ -1477,6 +1610,7 @@ static int mmc_test_profile_write_perf(struct mmc_test_card *test)
|
|
ret = mmc_test_area_erase(test);
|
|
ret = mmc_test_area_erase(test);
|
|
if (ret)
|
|
if (ret)
|
|
return ret;
|
|
return ret;
|
|
|
|
+ sz = test->area.max_tfr;
|
|
dev_addr = test->area.dev_addr;
|
|
dev_addr = test->area.dev_addr;
|
|
return mmc_test_area_io(test, sz, dev_addr, 1, 0, 1);
|
|
return mmc_test_area_io(test, sz, dev_addr, 1, 0, 1);
|
|
}
|
|
}
|
|
@@ -1516,29 +1650,63 @@ static int mmc_test_profile_trim_perf(struct mmc_test_card *test)
|
|
return 0;
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+static int mmc_test_seq_read_perf(struct mmc_test_card *test, unsigned long sz)
|
|
|
|
+{
|
|
|
|
+ unsigned int dev_addr, i, cnt;
|
|
|
|
+ struct timespec ts1, ts2;
|
|
|
|
+ int ret;
|
|
|
|
+
|
|
|
|
+ cnt = test->area.max_sz / sz;
|
|
|
|
+ dev_addr = test->area.dev_addr;
|
|
|
|
+ getnstimeofday(&ts1);
|
|
|
|
+ for (i = 0; i < cnt; i++) {
|
|
|
|
+ ret = mmc_test_area_io(test, sz, dev_addr, 0, 0, 0);
|
|
|
|
+ if (ret)
|
|
|
|
+ return ret;
|
|
|
|
+ dev_addr += (sz >> 9);
|
|
|
|
+ }
|
|
|
|
+ getnstimeofday(&ts2);
|
|
|
|
+ mmc_test_print_avg_rate(test, sz, cnt, &ts1, &ts2);
|
|
|
|
+ return 0;
|
|
|
|
+}
|
|
|
|
+
|
|
/*
|
|
/*
|
|
* Consecutive read performance by transfer size.
|
|
* Consecutive read performance by transfer size.
|
|
*/
|
|
*/
|
|
static int mmc_test_profile_seq_read_perf(struct mmc_test_card *test)
|
|
static int mmc_test_profile_seq_read_perf(struct mmc_test_card *test)
|
|
{
|
|
{
|
|
unsigned long sz;
|
|
unsigned long sz;
|
|
|
|
+ int ret;
|
|
|
|
+
|
|
|
|
+ for (sz = 512; sz < test->area.max_tfr; sz <<= 1) {
|
|
|
|
+ ret = mmc_test_seq_read_perf(test, sz);
|
|
|
|
+ if (ret)
|
|
|
|
+ return ret;
|
|
|
|
+ }
|
|
|
|
+ sz = test->area.max_tfr;
|
|
|
|
+ return mmc_test_seq_read_perf(test, sz);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static int mmc_test_seq_write_perf(struct mmc_test_card *test, unsigned long sz)
|
|
|
|
+{
|
|
unsigned int dev_addr, i, cnt;
|
|
unsigned int dev_addr, i, cnt;
|
|
struct timespec ts1, ts2;
|
|
struct timespec ts1, ts2;
|
|
int ret;
|
|
int ret;
|
|
|
|
|
|
- for (sz = 512; sz <= test->area.max_sz; sz <<= 1) {
|
|
|
|
- cnt = test->area.max_sz / sz;
|
|
|
|
- dev_addr = test->area.dev_addr;
|
|
|
|
- getnstimeofday(&ts1);
|
|
|
|
- for (i = 0; i < cnt; i++) {
|
|
|
|
- ret = mmc_test_area_io(test, sz, dev_addr, 0, 0, 0);
|
|
|
|
- if (ret)
|
|
|
|
- return ret;
|
|
|
|
- dev_addr += (sz >> 9);
|
|
|
|
- }
|
|
|
|
- getnstimeofday(&ts2);
|
|
|
|
- mmc_test_print_avg_rate(test, sz, cnt, &ts1, &ts2);
|
|
|
|
|
|
+ ret = mmc_test_area_erase(test);
|
|
|
|
+ if (ret)
|
|
|
|
+ return ret;
|
|
|
|
+ cnt = test->area.max_sz / sz;
|
|
|
|
+ dev_addr = test->area.dev_addr;
|
|
|
|
+ getnstimeofday(&ts1);
|
|
|
|
+ for (i = 0; i < cnt; i++) {
|
|
|
|
+ ret = mmc_test_area_io(test, sz, dev_addr, 1, 0, 0);
|
|
|
|
+ if (ret)
|
|
|
|
+ return ret;
|
|
|
|
+ dev_addr += (sz >> 9);
|
|
}
|
|
}
|
|
|
|
+ getnstimeofday(&ts2);
|
|
|
|
+ mmc_test_print_avg_rate(test, sz, cnt, &ts1, &ts2);
|
|
return 0;
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -1548,27 +1716,15 @@ static int mmc_test_profile_seq_read_perf(struct mmc_test_card *test)
|
|
static int mmc_test_profile_seq_write_perf(struct mmc_test_card *test)
|
|
static int mmc_test_profile_seq_write_perf(struct mmc_test_card *test)
|
|
{
|
|
{
|
|
unsigned long sz;
|
|
unsigned long sz;
|
|
- unsigned int dev_addr, i, cnt;
|
|
|
|
- struct timespec ts1, ts2;
|
|
|
|
int ret;
|
|
int ret;
|
|
|
|
|
|
- for (sz = 512; sz <= test->area.max_sz; sz <<= 1) {
|
|
|
|
- ret = mmc_test_area_erase(test);
|
|
|
|
|
|
+ for (sz = 512; sz < test->area.max_tfr; sz <<= 1) {
|
|
|
|
+ ret = mmc_test_seq_write_perf(test, sz);
|
|
if (ret)
|
|
if (ret)
|
|
return ret;
|
|
return ret;
|
|
- cnt = test->area.max_sz / sz;
|
|
|
|
- dev_addr = test->area.dev_addr;
|
|
|
|
- getnstimeofday(&ts1);
|
|
|
|
- for (i = 0; i < cnt; i++) {
|
|
|
|
- ret = mmc_test_area_io(test, sz, dev_addr, 1, 0, 0);
|
|
|
|
- if (ret)
|
|
|
|
- return ret;
|
|
|
|
- dev_addr += (sz >> 9);
|
|
|
|
- }
|
|
|
|
- getnstimeofday(&ts2);
|
|
|
|
- mmc_test_print_avg_rate(test, sz, cnt, &ts1, &ts2);
|
|
|
|
}
|
|
}
|
|
- return 0;
|
|
|
|
|
|
+ sz = test->area.max_tfr;
|
|
|
|
+ return mmc_test_seq_write_perf(test, sz);
|
|
}
|
|
}
|
|
|
|
|
|
/*
|
|
/*
|
|
@@ -1853,6 +2009,8 @@ static const struct mmc_test_case mmc_test_cases[] = {
|
|
|
|
|
|
static DEFINE_MUTEX(mmc_test_lock);
|
|
static DEFINE_MUTEX(mmc_test_lock);
|
|
|
|
|
|
|
|
+static LIST_HEAD(mmc_test_result);
|
|
|
|
+
|
|
static void mmc_test_run(struct mmc_test_card *test, int testcase)
|
|
static void mmc_test_run(struct mmc_test_card *test, int testcase)
|
|
{
|
|
{
|
|
int i, ret;
|
|
int i, ret;
|
|
@@ -1863,6 +2021,8 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase)
|
|
mmc_claim_host(test->card->host);
|
|
mmc_claim_host(test->card->host);
|
|
|
|
|
|
for (i = 0;i < ARRAY_SIZE(mmc_test_cases);i++) {
|
|
for (i = 0;i < ARRAY_SIZE(mmc_test_cases);i++) {
|
|
|
|
+ struct mmc_test_general_result *gr;
|
|
|
|
+
|
|
if (testcase && ((i + 1) != testcase))
|
|
if (testcase && ((i + 1) != testcase))
|
|
continue;
|
|
continue;
|
|
|
|
|
|
@@ -1881,6 +2041,25 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+ gr = kzalloc(sizeof(struct mmc_test_general_result),
|
|
|
|
+ GFP_KERNEL);
|
|
|
|
+ if (gr) {
|
|
|
|
+ INIT_LIST_HEAD(&gr->tr_lst);
|
|
|
|
+
|
|
|
|
+ /* Assign data what we know already */
|
|
|
|
+ gr->card = test->card;
|
|
|
|
+ gr->testcase = i;
|
|
|
|
+
|
|
|
|
+ /* Append container to global one */
|
|
|
|
+ list_add_tail(&gr->link, &mmc_test_result);
|
|
|
|
+
|
|
|
|
+ /*
|
|
|
|
+ * Save the pointer to created container in our private
|
|
|
|
+ * structure.
|
|
|
|
+ */
|
|
|
|
+ test->gr = gr;
|
|
|
|
+ }
|
|
|
|
+
|
|
ret = mmc_test_cases[i].run(test);
|
|
ret = mmc_test_cases[i].run(test);
|
|
switch (ret) {
|
|
switch (ret) {
|
|
case RESULT_OK:
|
|
case RESULT_OK:
|
|
@@ -1906,6 +2085,10 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase)
|
|
mmc_hostname(test->card->host), ret);
|
|
mmc_hostname(test->card->host), ret);
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+ /* Save the result */
|
|
|
|
+ if (gr)
|
|
|
|
+ gr->result = ret;
|
|
|
|
+
|
|
if (mmc_test_cases[i].cleanup) {
|
|
if (mmc_test_cases[i].cleanup) {
|
|
ret = mmc_test_cases[i].cleanup(test);
|
|
ret = mmc_test_cases[i].cleanup(test);
|
|
if (ret) {
|
|
if (ret) {
|
|
@@ -1923,30 +2106,95 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase)
|
|
mmc_hostname(test->card->host));
|
|
mmc_hostname(test->card->host));
|
|
}
|
|
}
|
|
|
|
|
|
-static ssize_t mmc_test_show(struct device *dev,
|
|
|
|
- struct device_attribute *attr, char *buf)
|
|
|
|
|
|
+static void mmc_test_free_result(struct mmc_card *card)
|
|
{
|
|
{
|
|
|
|
+ struct mmc_test_general_result *gr, *grs;
|
|
|
|
+
|
|
mutex_lock(&mmc_test_lock);
|
|
mutex_lock(&mmc_test_lock);
|
|
|
|
+
|
|
|
|
+ list_for_each_entry_safe(gr, grs, &mmc_test_result, link) {
|
|
|
|
+ struct mmc_test_transfer_result *tr, *trs;
|
|
|
|
+
|
|
|
|
+ if (card && gr->card != card)
|
|
|
|
+ continue;
|
|
|
|
+
|
|
|
|
+ list_for_each_entry_safe(tr, trs, &gr->tr_lst, link) {
|
|
|
|
+ list_del(&tr->link);
|
|
|
|
+ kfree(tr);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ list_del(&gr->link);
|
|
|
|
+ kfree(gr);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ mutex_unlock(&mmc_test_lock);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static LIST_HEAD(mmc_test_file_test);
|
|
|
|
+
|
|
|
|
+static int mtf_test_show(struct seq_file *sf, void *data)
|
|
|
|
+{
|
|
|
|
+ struct mmc_card *card = (struct mmc_card *)sf->private;
|
|
|
|
+ struct mmc_test_general_result *gr;
|
|
|
|
+
|
|
|
|
+ mutex_lock(&mmc_test_lock);
|
|
|
|
+
|
|
|
|
+ list_for_each_entry(gr, &mmc_test_result, link) {
|
|
|
|
+ struct mmc_test_transfer_result *tr;
|
|
|
|
+
|
|
|
|
+ if (gr->card != card)
|
|
|
|
+ continue;
|
|
|
|
+
|
|
|
|
+ seq_printf(sf, "Test %d: %d\n", gr->testcase + 1, gr->result);
|
|
|
|
+
|
|
|
|
+ list_for_each_entry(tr, &gr->tr_lst, link) {
|
|
|
|
+ seq_printf(sf, "%u %d %lu.%09lu %u\n",
|
|
|
|
+ tr->count, tr->sectors,
|
|
|
|
+ (unsigned long)tr->ts.tv_sec,
|
|
|
|
+ (unsigned long)tr->ts.tv_nsec,
|
|
|
|
+ tr->rate);
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+
|
|
mutex_unlock(&mmc_test_lock);
|
|
mutex_unlock(&mmc_test_lock);
|
|
|
|
|
|
return 0;
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
|
|
-static ssize_t mmc_test_store(struct device *dev,
|
|
|
|
- struct device_attribute *attr, const char *buf, size_t count)
|
|
|
|
|
|
+static int mtf_test_open(struct inode *inode, struct file *file)
|
|
{
|
|
{
|
|
- struct mmc_card *card;
|
|
|
|
|
|
+ return single_open(file, mtf_test_show, inode->i_private);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static ssize_t mtf_test_write(struct file *file, const char __user *buf,
|
|
|
|
+ size_t count, loff_t *pos)
|
|
|
|
+{
|
|
|
|
+ struct seq_file *sf = (struct seq_file *)file->private_data;
|
|
|
|
+ struct mmc_card *card = (struct mmc_card *)sf->private;
|
|
struct mmc_test_card *test;
|
|
struct mmc_test_card *test;
|
|
- int testcase;
|
|
|
|
|
|
+ char lbuf[12];
|
|
|
|
+ long testcase;
|
|
|
|
|
|
- card = container_of(dev, struct mmc_card, dev);
|
|
|
|
|
|
+ if (count >= sizeof(lbuf))
|
|
|
|
+ return -EINVAL;
|
|
|
|
|
|
- testcase = simple_strtol(buf, NULL, 10);
|
|
|
|
|
|
+ if (copy_from_user(lbuf, buf, count))
|
|
|
|
+ return -EFAULT;
|
|
|
|
+ lbuf[count] = '\0';
|
|
|
|
+
|
|
|
|
+ if (strict_strtol(lbuf, 10, &testcase))
|
|
|
|
+ return -EINVAL;
|
|
|
|
|
|
test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL);
|
|
test = kzalloc(sizeof(struct mmc_test_card), GFP_KERNEL);
|
|
if (!test)
|
|
if (!test)
|
|
return -ENOMEM;
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
+ /*
|
|
|
|
+ * Remove all test cases associated with given card. Thus we have only
|
|
|
|
+ * actual data of the last run.
|
|
|
|
+ */
|
|
|
|
+ mmc_test_free_result(card);
|
|
|
|
+
|
|
test->card = card;
|
|
test->card = card;
|
|
|
|
|
|
test->buffer = kzalloc(BUFFER_SIZE, GFP_KERNEL);
|
|
test->buffer = kzalloc(BUFFER_SIZE, GFP_KERNEL);
|
|
@@ -1973,16 +2221,78 @@ static ssize_t mmc_test_store(struct device *dev,
|
|
return count;
|
|
return count;
|
|
}
|
|
}
|
|
|
|
|
|
-static DEVICE_ATTR(test, S_IWUSR | S_IRUGO, mmc_test_show, mmc_test_store);
|
|
|
|
|
|
+static const struct file_operations mmc_test_fops_test = {
|
|
|
|
+ .open = mtf_test_open,
|
|
|
|
+ .read = seq_read,
|
|
|
|
+ .write = mtf_test_write,
|
|
|
|
+ .llseek = seq_lseek,
|
|
|
|
+ .release = single_release,
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
+static void mmc_test_free_file_test(struct mmc_card *card)
|
|
|
|
+{
|
|
|
|
+ struct mmc_test_dbgfs_file *df, *dfs;
|
|
|
|
+
|
|
|
|
+ mutex_lock(&mmc_test_lock);
|
|
|
|
+
|
|
|
|
+ list_for_each_entry_safe(df, dfs, &mmc_test_file_test, link) {
|
|
|
|
+ if (card && df->card != card)
|
|
|
|
+ continue;
|
|
|
|
+ debugfs_remove(df->file);
|
|
|
|
+ list_del(&df->link);
|
|
|
|
+ kfree(df);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ mutex_unlock(&mmc_test_lock);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static int mmc_test_register_file_test(struct mmc_card *card)
|
|
|
|
+{
|
|
|
|
+ struct dentry *file = NULL;
|
|
|
|
+ struct mmc_test_dbgfs_file *df;
|
|
|
|
+ int ret = 0;
|
|
|
|
+
|
|
|
|
+ mutex_lock(&mmc_test_lock);
|
|
|
|
+
|
|
|
|
+ if (card->debugfs_root)
|
|
|
|
+ file = debugfs_create_file("test", S_IWUSR | S_IRUGO,
|
|
|
|
+ card->debugfs_root, card, &mmc_test_fops_test);
|
|
|
|
+
|
|
|
|
+ if (IS_ERR_OR_NULL(file)) {
|
|
|
|
+ dev_err(&card->dev,
|
|
|
|
+ "Can't create file. Perhaps debugfs is disabled.\n");
|
|
|
|
+ ret = -ENODEV;
|
|
|
|
+ goto err;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ df = kmalloc(sizeof(struct mmc_test_dbgfs_file), GFP_KERNEL);
|
|
|
|
+ if (!df) {
|
|
|
|
+ debugfs_remove(file);
|
|
|
|
+ dev_err(&card->dev,
|
|
|
|
+ "Can't allocate memory for internal usage.\n");
|
|
|
|
+ ret = -ENOMEM;
|
|
|
|
+ goto err;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ df->card = card;
|
|
|
|
+ df->file = file;
|
|
|
|
+
|
|
|
|
+ list_add(&df->link, &mmc_test_file_test);
|
|
|
|
+
|
|
|
|
+err:
|
|
|
|
+ mutex_unlock(&mmc_test_lock);
|
|
|
|
+
|
|
|
|
+ return ret;
|
|
|
|
+}
|
|
|
|
|
|
static int mmc_test_probe(struct mmc_card *card)
|
|
static int mmc_test_probe(struct mmc_card *card)
|
|
{
|
|
{
|
|
int ret;
|
|
int ret;
|
|
|
|
|
|
- if ((card->type != MMC_TYPE_MMC) && (card->type != MMC_TYPE_SD))
|
|
|
|
|
|
+ if (!mmc_card_mmc(card) && !mmc_card_sd(card))
|
|
return -ENODEV;
|
|
return -ENODEV;
|
|
|
|
|
|
- ret = device_create_file(&card->dev, &dev_attr_test);
|
|
|
|
|
|
+ ret = mmc_test_register_file_test(card);
|
|
if (ret)
|
|
if (ret)
|
|
return ret;
|
|
return ret;
|
|
|
|
|
|
@@ -1993,7 +2303,8 @@ static int mmc_test_probe(struct mmc_card *card)
|
|
|
|
|
|
static void mmc_test_remove(struct mmc_card *card)
|
|
static void mmc_test_remove(struct mmc_card *card)
|
|
{
|
|
{
|
|
- device_remove_file(&card->dev, &dev_attr_test);
|
|
|
|
|
|
+ mmc_test_free_result(card);
|
|
|
|
+ mmc_test_free_file_test(card);
|
|
}
|
|
}
|
|
|
|
|
|
static struct mmc_driver mmc_driver = {
|
|
static struct mmc_driver mmc_driver = {
|
|
@@ -2011,6 +2322,10 @@ static int __init mmc_test_init(void)
|
|
|
|
|
|
static void __exit mmc_test_exit(void)
|
|
static void __exit mmc_test_exit(void)
|
|
{
|
|
{
|
|
|
|
+ /* Clear stalled data if card is still plugged */
|
|
|
|
+ mmc_test_free_result(NULL);
|
|
|
|
+ mmc_test_free_file_test(NULL);
|
|
|
|
+
|
|
mmc_unregister_driver(&mmc_driver);
|
|
mmc_unregister_driver(&mmc_driver);
|
|
}
|
|
}
|
|
|
|
|